[Testing] 7.x Disable geoip downloader#25272
Merged
andrewkroh merged 1 commit intoelastic:7.xfrom Apr 23, 2021
Merged
Conversation
Disable database updates via an Elasticsearch property ingest.geoip.downloader.enabled: false. This will cause Elasticsearch to use the circa 2019 maxmind database version that is embedded. This would work for now, but the embedded database will be removed in 8.x IIUC. This prevents our golden file tests from failing everytime the database changes geo or asn values. It also prevents race conditions in tests that might run before the database has been updated or in cases where the downloader service is unavailable. Closes: elastic#25159
botelastic
Bot
added
the
needs_team
|
This pull request doesn't have a |
kvch
approved these changes
Apr 23, 2021
Contributor
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Test errors
Expand to view the tests failures
|
| Test | Results |
|---|---|
| Failed | 1 |
| Passed | 47163 |
| Skipped | 5184 |
| Total | 52348 |
Genuine test errors 
💔 There are test failures but not known flaky tests, most likely a genuine test failure.
- Name:
Build&Test / auditbeat-windows-10-windows-10 / TestNonRecursive – github.com/elastic/beats/v7/auditbeat/module/file_integrity/monitor
Member
Author
|
Merging with some red b/c we need to get 7.x and 7.13 branches "more green" than they are. They generator tests that failed should be fixed by another PR that has since been merged. |
andrewkroh
added
needs_backport
3 tasks
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Apr 23, 2021
Disable database updates via an Elasticsearch property ingest.geoip.downloader.enabled: false. This will cause Elasticsearch to use the circa 2019 maxmind database version that is embedded. This would work for now, but the embedded database will be removed in 8.x IIUC. This prevents our golden file tests from failing everytime the database changes geo or asn values. It also prevents race conditions in tests that might run before the database has been updated or in cases where the downloader service is unavailable. Closes: elastic#25159 (cherry picked from commit 3b4b10e)
andrewkroh
added
v7.13.0
and removed
needs_backport
andrewkroh
added a commit
that referenced
this pull request
Apr 23, 2021
Disable database updates via an Elasticsearch property ingest.geoip.downloader.enabled: false. This will cause Elasticsearch to use the circa 2019 maxmind database version that is embedded. This would work for now, but the embedded database will be removed in 8.x IIUC. This prevents our golden file tests from failing everytime the database changes geo or asn values. It also prevents race conditions in tests that might run before the database has been updated or in cases where the downloader service is unavailable. Closes: #25159 (cherry picked from commit 3b4b10e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same change as #25248 but not automated b/c the branches differ in that golden files don't need updated in 7.x. Once 7.14.0-SNAPSHOT is ready #25192 will update them, but for now use 7.13.0-SNAPSHOT of the stack.
What does this PR do?
Disable database updates via an Elasticsearch property ingest.geoip.downloader.enabled: false. This will cause Elasticsearch to use the circa 2019 maxmind database version that is embedded. This would work for now, but the embedded database will be removed in 8.x IIUC.
Closes: #25159
Why is it important?
This prevents our golden file tests from failing everytime the database changes geo or asn values. It also prevents race conditions in tests that might run before the database has been updated or in cases where the downloader service is unavailable.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues